Skip to content

Conversation

dckc
Copy link
Member

@dckc dckc commented Sep 25, 2025

Description

Security / Scaling / Upgrade Considerations

pure refactor; no runtime impact

Documentation / Testing Considerations

clarifies boundaries of contract a bit

@dckc dckc self-assigned this Sep 25, 2025
Copy link

cloudflare-workers-and-pages bot commented Sep 26, 2025

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 015f1ad
Status: ✅  Deploy successful!
Preview URL: https://516da943.agoric-sdk.pages.dev
Branch Preview URL: https://dc-mv-plan-tools.agoric-sdk.pages.dev

View logs

@dckc dckc marked this pull request as ready for review September 26, 2025 05:10
@dckc dckc requested a review from a team as a code owner September 26, 2025 05:10
@dckc dckc added automerge:rebase Automatically rebase updates, then merge bypass:integration Prevent integration tests from running on PR labels Sep 26, 2025
@mergify mergify bot added the queued label Sep 26, 2025
mergify bot added a commit that referenced this pull request Sep 26, 2025
mergify bot added a commit that referenced this pull request Sep 26, 2025
@mergify mergify bot removed the queued label Sep 26, 2025
Copy link
Contributor

mergify bot commented Sep 26, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #11988 has been dequeued. Mergify failed to merge the pull request. GitHub can't merge the pull request after 15 retries.
Waiting for the branch protection required status checks to be validated.

You can check the last failing draft PR here: #12007.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@LuqiPan
Copy link
Contributor

LuqiPan commented Sep 26, 2025

@Mergifyio requeue

Copy link
Contributor

mergify bot commented Sep 26, 2025

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify mergify bot added the queued label Sep 26, 2025
mergify bot added a commit that referenced this pull request Sep 26, 2025
@mergify mergify bot removed the queued label Sep 26, 2025
Copy link
Contributor

mergify bot commented Sep 26, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #11988 has been dequeued. Mergify failed to merge the pull request. GitHub can't merge the pull request after 15 retries.
Waiting for the branch protection required status checks to be validated.

You can check the last failing draft PR here: #12010.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify mergify bot added queued and removed queued labels Sep 26, 2025
Copy link
Contributor

mergify bot commented Sep 26, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #11988 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (details: Required status check "merge-strategy (chosen)" is queued.).

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify mergify bot added queued and removed queued labels Sep 26, 2025
Copy link
Contributor

mergify bot commented Sep 26, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #11988 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (details: Required status check "merge-strategy (chosen)" is in progress.).

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@dtribble dtribble added automerge:rebase Automatically rebase updates, then merge and removed automerge:rebase Automatically rebase updates, then merge labels Sep 26, 2025
@mergify mergify bot added the queued label Sep 26, 2025
Copy link
Contributor

mergify bot commented Sep 26, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #11988 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (details: Required status check "merge-strategy (chosen)" is in progress.).

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify mergify bot removed the queued label Sep 26, 2025
@dtribble dtribble added bypass:automerge Allow manually merging a PR and removed automerge:rebase Automatically rebase updates, then merge labels Sep 27, 2025
@dtribble dtribble merged commit 96c9c4f into master Sep 27, 2025
202 of 206 checks passed
@dtribble dtribble deleted the dc-mv-plan-tools branch September 27, 2025 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bypass:automerge Allow manually merging a PR bypass:integration Prevent integration tests from running on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants